-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP] Call controller actions using URL from _publicApi instead of _query endpoint #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
reviewed
Apr 25, 2022
Shiranuit
force-pushed
the
call-proper-http-routes
branch
from
April 25, 2022 17:32
05af4e1
to
7c33d83
Compare
src/main/kotlin/io/kuzzle/sdk/coreClasses/exceptions/ApiErrorException.kt
Show resolved
Hide resolved
src/main/kotlin/io/kuzzle/sdk/coreClasses/exceptions/MissingActionException.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/kuzzle/sdk/coreClasses/exceptions/MissingControllerException.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/kuzzle/sdk/coreClasses/exceptions/MissingURLParamException.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/io/kuzzle/sdk/coreClasses/exceptions/URLNotFoundException.kt
Outdated
Show resolved
Hide resolved
…/sdk-jvm into call-proper-http-routes
… into call-proper-http-routes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on kuzzleio/kuzzle#2342
The tests will not pass until this PR (kuzzleio/kuzzle#2342) is merged and Kuzzle is released.
What does this PR do ?
This PR add the capability of calling controller's actions directly using their HTTP Endpoint instead of using the _query endpoint.
The SDK is going to try to fetch HTTP Endpoint from
/_publicApi
and build the routes to directly call the HTTP Endpoint.If the SDK cannot fetch or build the routes from
/_publicApi
, it will fallback using the/_query
endpointOther changes
Headers can now be added by adding a headers property in the request sent using query
Headers are returned in the Response object