Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] fix typos and fix rdma device selection when retry_count != 0 #33

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[Bugfix] fix typos and fix rdma device selection when retry_count != 0 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mooncake-transfer-engine/include/transport/rdma_transport/rdma_endpoint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace mooncake {

// RdmaEndPoint represents all QP connections between the local NIC1 (identified
// by its RdmaContext) and the remote NIC2 (identified by peer_nic_path).
// 1. After ctor, resources are allocated without specifying the peers.
// 1. After construct, resources are allocated without specifying the peers.
// 2. Handshake information needs to be exchanged with remote RdmaEndPoint.
// - Local side calls the setupConnectionsByActive() function, passing in the
// peer_nic_path of the remote side
Expand Down
2 changes: 1 addition & 1 deletion mooncake-transfer-engine/src/transport/rdma_transport/endpoint_store.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ std::shared_ptr<RdmaEndPoint> SIEVEEndpointStore::insertEndpoint(
RWSpinlock::WriteGuard guard(endpoint_map_lock_);
if (endpoint_map_.find(peer_nic_path) != endpoint_map_.end()) {
LOG(INFO) << "Endpoint " << peer_nic_path
<< " already exists in FIFOEndpointStore";
<< " already exists in SIEVEEndpointStore";
return endpoint_map_[peer_nic_path].first;
}
auto endpoint = std::make_shared<RdmaEndPoint>(*context);
Expand Down
4 changes: 2 additions & 2 deletions mooncake-transfer-engine/src/transport/rdma_transport/rdma_transport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,9 @@ int RdmaTransport::selectDevice(SegmentDesc *desc, uint64_t offset,
} else {
size_t index = (retry_count - 1) % rnic_list_len;
if (index < preferred_rnic_list_len)
device_id = index;
device_id = priority.preferred_rnic_id_list[index];
else
device_id = index - preferred_rnic_list_len;
device_id = priority.available_rnic_id_list[index - preferred_rnic_list_len];
}

return 0;
Expand Down