Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TransferEngine] Correct the count of slice_quque_ in rdma/worker_pool, remove the repeated check for overlap #79

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[TransferEngine] Correct the count of slice_quque_ in rdma/worker_pool, remove the repeated check for overlap #79

merged 2 commits into from
Jan 14, 2025

Conversation

fengquyoumo
Copy link
Contributor

@fengquyoumo fengquyoumo commented Jan 13, 2025 •
edited
Loading

  1. Correct the count of slice_queue_, although it has no adverse effects
  2. The overlap check in rdma_transport is repeat with checkOverlap in TransferEngine::registerLocalMemory which is better

@fengquyoumo fengquyoumo changed the title [TransferEngine] correct the count of slice_quque_ in rdma/worker_pool, remove the repeated check for overlap [TransferEngine] Correct the count of slice_quque_ in rdma/worker_pool, remove the repeated check for overlap Jan 13, 2025
doujiang24
doujiang24 approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@doujiang24 doujiang24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, lgtm.

@alogfans alogfans merged commit dd2b56b into kvcache-ai:main Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doujiang24 doujiang24 doujiang24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengquyoumo @doujiang24 @alogfans