Merge pull request #3 from kwameopareasiedu/remove-validate-on-reset

Remove validate on reset

README.md

@@ -233,3 +233,8 @@ form.handleSubmit((values: T) => void): (values: T) => void
 ## Contributors
 
 - [Kwame Opare Asiedu](https://github.com/kwameopareasiedu)
+
+## Changelog
+
+- 1.0.2 (Current)
+  - Disabled call to `form.validateField` on `form.reset` to avoid errors on form reset

example/src/app.ts

@@ -9,7 +9,7 @@ export default function App() {
   const form = new Form({
     initialValues: {
       input: "",
-      range: 50,
+      range: 30,
       select: "",
       radio: "",
       checkbox: false

package.json

@@ -1,11 +1,17 @@
 {
   "name": "vanjs-form",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Fully typed form state management library (with validation) for VanJS",
   "repository": "https://github.com/kwameopareasiedu/vanjs-form",
   "homepage": "https://github.com/kwameopareasiedu/vanjs-form",
-  "keywords": ["vanjs", "form", "validation"],
-  "maintainers": ["Kwame Opare Asiedu"],
+  "keywords": [
+    "vanjs",
+    "form",
+    "validation"
+  ],
+  "maintainers": [
+    "Kwame Opare Asiedu"
+  ],
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "author": "Kwame Opare Asiedu",
@@ -18,18 +24,18 @@
   },
   "devDependencies": {
     "@rollup/plugin-terser": "^0.4.4",
-    "@rollup/plugin-typescript": "^11.1.5",
-    "@typescript-eslint/eslint-plugin": "^6.16.0",
-    "@typescript-eslint/parser": "^6.16.0",
-    "eslint": "^8.56.0",
-    "prettier": "3.1.1",
-    "rollup": "^4.9.1",
-    "tslib": "^2.6.2"
+    "@rollup/plugin-typescript": "^11.1.6",
+    "@typescript-eslint/eslint-plugin": "^7.12.0",
+    "@typescript-eslint/parser": "^7.12.0",
+    "eslint": "8.57.0",
+    "prettier": "3.3.1",
+    "rollup": "^4.18.0",
+    "tslib": "^2.6.3"
   },
   "dependencies": {
-    "typescript": "^5.3.3",
-    "vanjs-core": "^1.2.7",
-    "yup": "^1.3.3"
+    "typescript": "^5.4.5",
+    "vanjs-core": "^1.5.0",
+    "yup": "^1.4.0"
   },
   "peerDependencies": {
     "vanjs-core": "^1.2.7",

src/index.ts

@@ -142,7 +142,7 @@ export class Form<T extends Record<string, unknown>> {
         field.touched.val = false;
         field.error.val = "";
 
-        if (this.validationMode === "oninput") this.validateField(name);
+        // if (this.validationMode === "oninput") this.validateField(name);
       }
     } else {
       for (const key in this.fields) {
@@ -151,7 +151,7 @@ export class Form<T extends Record<string, unknown>> {
         field.touched.val = false;
         field.error.val = "";
 
-        if (this.validationMode === "oninput") this.validateField(key);
+        // if (this.validationMode === "oninput") this.validateField(key);
       }
     }
   }