fix: codeblock component was printing code to screen.. weird (#88)

kwicherbelliaken · Jun 29, 2023 · 6c8a4d6 · 6c8a4d6
1 parent 2bbc102
commit 6c8a4d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/components/CodeBlock.tsx b/app/components/CodeBlock.tsx
@@ -37,7 +37,6 @@ const CodeBlock = ({
         </code>
       </pre>
       <P styleProps={["italic"]}>{caption}</P>
-      <div>{code}</div>
     </div>
   );
 };

diff --git a/app/routes/braindumps.list.$braindumpId.tsx b/app/routes/braindumps.list.$braindumpId.tsx
@@ -33,7 +33,6 @@ type LoaderData = {
 };
 
 export const loader: LoaderFunction = async ({ params }) => {
-
   /* 1. retrieve the Notion Page equivalent of this Braindump */
   const response: Page = await notionClient.pages.retrieve({
     page_id: params.braindumpId,
@@ -306,12 +305,13 @@ const useNotionInterpretBlocks = (
             return null;
 
           case "code":
-            // todo: throw an error if a code block is missing a caption
             return (
               <CodeBlock
                 key={block.id}
                 content={{
-                  caption: block.code.caption[0].plain_text,
+                  ...(block.code.caption[0] && {
+                    caption: block.code.caption[0].plain_text,
+                  }),
                   code: block.code.rich_text[0].plain_text,
                 }}
               />
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,7 +37,6 @@ const CodeBlock = ({ @@
             </code>
           </pre>
           <P styleProps={["italic"]}>{caption}</P>
-          <div>{code}</div>
         </div>
       );
     };
@@ Expand Down @@