Adjust PR workflow to the new test strategy (#1294)

* Adjust PR workflow to the new test strategy

* Improvements

* Add build job for the image that allows to push to external img registry

* Rename workflow

.github/workflows/pull-integration.yaml → .github/workflows/call-pull-e2e.yaml

@@ -1,7 +1,4 @@
-# This workflow is responsible for all kinds of integration tests run on pull request.
-# Those tests depend on a container image so in the first job we wait for the image build to succeed.
-
-name: Pull Request integration tests
+name: PR E2E
 
 on:
   workflow_call:
@@ -27,44 +24,8 @@ jobs:
             .reuse/**
             external-images.yaml
 
-  k8s-compatibility-test:
-    name: Kubernetes version compatibility test
-    runs-on: ubuntu-latest
-    needs: [ changed-files ]
-    if: needs.changed-files.outputs.any_modified == 'true'
-    strategy:
-      fail-fast: false
-      matrix:
-        test_make_target: [ "configuration-integration-test", "mesh-communication-integration-test", "installation-integration-test", "observability-integration-test" ]
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./.github/actions/load-manager-image
-      - uses: ./.github/actions/k8s-compatibility-test
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          test_make_target: ${{ matrix.test_make_target }}
-          operator-image-name: "istio-manager:PR-${{github.event.number}}"
-
-  istio-upgrade-integration-test:
-    name: Istio upgrade integration test
-    runs-on: ubuntu-latest
-    needs: [ changed-files ]
-    if: needs.changed-files.outputs.any_modified == 'true'
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-      - uses: ./.github/actions/load-manager-image
-      - uses: ./.github/actions/upgrade-integration-test
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        with:
-          operator-image-name: "istio-manager:PR-${{github.event.number}}"
-          target_branch: ${{ github.base_ref }}
-
-  istio-integration-test:
-    name: Istio integration test
+  istio-e2e-test-k3d:
+    name: Istio E2E test - k3d
     runs-on: ubuntu-latest
     needs: [ changed-files ]
     if: needs.changed-files.outputs.any_modified == 'true'
@@ -86,8 +47,8 @@ jobs:
           servers-memory: "16"
           agents: 2
 
-  istio-integration-test-evaluation:
-    name: Istio integration test evaluation
+  istio-e2e-test-evaluation-k3d:
+    name: Istio E2E test (evaluation) - k3d
     runs-on: ubuntu-latest
     needs: [ changed-files ]
     if: needs.changed-files.outputs.any_modified == 'true'

.github/workflows/pull-build-push.yaml

@@ -0,0 +1,32 @@
+name: PR Build and Push Manager Image
+
+on:
+  pull_request_target:
+    types: [ synchronize, opened, reopened, ready_for_review ]
+    paths-ignore:
+      - "docs/**"
+      - "**/*.md"
+      - "tests/performance/**"
+      - "OWNERS"
+      - "CODEOWNERS"
+      - ".github/**" #Ignoring since build job isn't triggered on the workflow directory changes
+      - "external-images.yaml"
+    branches:
+      - 'main'
+
+jobs:
+  build-image:
+    name: Build and push manager image
+    environment: ${{ github.event.pull_request.author_association != 'COLLABORATOR' && github.event.pull_request.author_association != 'OWNER' && 'restricted' || 'internal' }}
+    runs-on: ubuntu-latest
+    if: ${{ github.event.pull_request.draft == false }}
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 0
+      - uses: ./.github/actions/build-manager-image
+        with:
+          operator-image-name: "europe-central2-docker.pkg.dev/sap-se-cx-kyma-goat/istio/istio-manager:PR-${{github.event.number}}"
+          push-image: 'true'
+          push-sa-key: ${{ secrets.GCP_SA_KEY }}

.github/workflows/pull-request.yaml

@@ -1,4 +1,4 @@
-name: Pull Request pipeline
+name: Pull Request
 on:
   pull_request:
     types: [ synchronize, opened, reopened, ready_for_review ]
@@ -38,17 +38,10 @@ jobs:
     if: github.event.pull_request.draft == false
     secrets: inherit
 
-  integration-tests:
+  e2e-tests:
     name: Dispatch integration tests
     needs: [build-image]
-    uses: ./.github/workflows/pull-integration.yaml
-    if: github.event.pull_request.draft == false
-    secrets: inherit
-
-  ui-tests:
-    name: Dispatch UI tests
-    needs: [build-image]
-    uses: ./.github/workflows/call-ui-tests.yaml
+    uses: ./.github/workflows/call-pull-e2e.yaml
     if: github.event.pull_request.draft == false
     secrets: inherit
 
@@ -59,7 +52,7 @@ jobs:
     secrets: inherit
 
   pull-request-status:
-    needs: [ build-image, unit-tests, integration-tests, ui-tests, verify-pins ]
+    needs: [ build-image, unit-tests, e2e-tests, verify-pins ]
     runs-on: ubuntu-latest
     if: always()
     steps: