Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh updateAt operation field to measure timeout #1661

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Refresh updateAt operation field to measure timeout #1661

merged 3 commits into from
Jan 21, 2025

Conversation

piotrmiskiewicz
Copy link
Member

Description

Changes proposed in this pull request:

  • Check runtime resource step is repeated for a long time but it wasn't updating the operation - so the next step cannot calculate timeout.
  • This PR adds a dummy update to have proper updatedAt value

Related issue(s)

@piotrmiskiewicz piotrmiskiewicz requested a review from a team as a code owner January 21, 2025 12:38
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 21, 2025
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) January 21, 2025 12:39
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2025
@piotrmiskiewicz
Copy link
Member Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@jaroslaw-pieszka jaroslaw-pieszka self-requested a review January 21, 2025 12:46
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 21, 2025
@jaroslaw-pieszka jaroslaw-pieszka added the kind/bug Categorizes issue or PR as related to a bug. label Jan 21, 2025
@piotrmiskiewicz
Copy link
Member Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@kyma-gopher-bot kyma-gopher-bot merged commit 6ddd5ea into kyma-project:main Jan 21, 2025
26 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@piotrmiskiewicz piotrmiskiewicz

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotrmiskiewicz @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot