Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI API Layer module pluggability #1883

Closed
11 tasks done
pkosiec opened this issue Nov 30, 2018 · 3 comments
Closed
11 tasks done

UI API Layer module pluggability #1883

pkosiec opened this issue Nov 30, 2018 · 3 comments
Assignees
Labels
area/busola Related to all activities around the Busola UI and all its views kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pkosiec
Copy link
Contributor

pkosiec commented Nov 30, 2018

Description

Implement module pluggability for UI API Layer, according to the accepted proposal: kyma-project/community#141

Documentation

UI API Layer

Console UI

  • Set up a meeting with UI teams to show how to make resilient UIs, when some UI API Layer modules are turned off. Prepare example of modularity in the Service Catalog UI
  • Review all Console UI views - which crash when a module is not available. Prepare a list and working cluster. Best would be to do a pull request with such simulation. Remember about UI tests in the demo

Reasons

UI API Layer exposes GraphQL API for the Kyma Console. It consists of resolver logic for different domains, like Kubernetes, Service Catalog, Remote Environments, Kubeless, etc. As Kyma needs to be modularized, users should be able to install only the components they need.

The current approach we use in UI API Layer makes it impossible. During the GraphQL server start, we try to synchronize Stores of all Informers. As a result, if a resource of a specific type doesn't exist, UI API Layer won't start properly because its Informer will return an error.

@pkosiec pkosiec added kind/feature Categorizes issue or PR as related to a new feature. area/busola Related to all activities around the Busola UI and all its views labels Nov 30, 2018
@pkosiec pkosiec added this to the Backlog_Wookiee milestone Nov 30, 2018
@derberg derberg modified the milestones: Backlog_Wookiee, Sprint_Wookiee_7 Dec 4, 2018
@derberg derberg added stale and removed stale labels Dec 5, 2018
@pkosiec
Copy link
Contributor Author

pkosiec commented Dec 12, 2018

Please consider using GraphQL directives: https://gqlgen.com/reference/directives/

@mjasinski5 mjasinski5 modified the milestones: Sprint_Wookiee_7, Sprint_Wookiee_8 Dec 17, 2018
@pkosiec pkosiec self-assigned this Dec 17, 2018
@pkosiec pkosiec added the Epic label Dec 17, 2018
@pkosiec pkosiec changed the title Implement UI API Layer module pluggability UI API Layer module pluggability Dec 17, 2018
@pkosiec pkosiec removed the Epic label Dec 17, 2018
@mjasinski5
Copy link
Contributor

Review: @michal-hudy

@mjasinski5
Copy link
Contributor

#2084 Review: @michal-hudy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/busola Related to all activities around the Busola UI and all its views kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants