Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Application Connector documentation #1286

Merged
merged 4 commits into from
Oct 16, 2018

Conversation

tomekpapiernik
Copy link
Contributor

Changes proposed in this pull request:

  • Minor fixes and improvements to wording.
  • CRD documents' names updated to follow the guidelines
  • API specification links changed from relative to absolute

Related issue(s)
See #1283

Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes

@@ -18,4 +18,4 @@ The AC gives you the following:

All of the AC components scale independently, which allows to adjust it to fit the needs of the implementation built using Kyma.

>**NOTE:** To learn more about the Environments in Kyma, read the **Environments** document in the **Kyma** documentation topic.
>**NOTE:** To learn more about the concept Environments in Kyma, read the **Environments** document in the **Kyma** documentation topic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept > concept of?

@@ -2,11 +2,11 @@
title: Overview
---

The Application Connector (AC) is a proprietary Kyma implementation that allows you to connect with external solutions. No matter if you want to integrate an on-premise or a cloud system, the integration process doesn't change, which allows to avoid any configuration and network-related problems.
The Application Connector (AC) is a proprietary Kyma implementation that allows you to connect with external solutions. No matter if you want to integrate an on-premise or a cloud system, the integration process doesn't change, which allows to avoid any configuration or network-related problems.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't > does not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be so strict about contractions. We allow them where they sound natural, that's the consensus ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, got it :)

@tomekpapiernik tomekpapiernik added area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation kind/bug Categorizes issue or PR as related to a bug. labels Oct 16, 2018
@tomekpapiernik tomekpapiernik self-assigned this Oct 16, 2018
@tomekpapiernik tomekpapiernik added this to the Sprint_Framefrog_3 milestone Oct 16, 2018
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tomekpapiernik tomekpapiernik merged commit befb611 into kyma-project:master Oct 16, 2018
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants