Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to observability tutorial #16341

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Dec 12, 2022

Description

Observability link in docs was not shown due to missing children.

Changes proposed in this pull request:

  • Fix link to observability tutorial

Related issue(s)

#15914

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2022
@netlify
Copy link

netlify bot commented Dec 12, 2022

🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit 0218f43
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6397030135051d000963c68c
😎 Deploy Preview https://deploy-preview-16341--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2022
@kyma-bot
Copy link
Contributor

@chrkl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-function-java17-jvm-alpha-build c52fd88 link true /test pull-function-java17-jvm-alpha-build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrkl chrkl force-pushed the fix-observability-link branch from c52fd88 to 100623b Compare December 13, 2022 10:30
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 13, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2022
@@ -4,7 +4,7 @@ title: Observability - Useful links

If you're interested in learning more about the Observability area, check out these links:

- Learn how to set up the [Monitoring Flow](../../../03-tutorials/00-observability) for your services in Kyma, in which you [observe your application metrics](../../../03-tutorials/00-observability/obsv-01-observe-application-metrics.md), [set up your Grafana Dashboard](../../../03-tutorials/00-observability/obsv-02-create-and-configure-grafana-dashboard.md), [define alerting rules](../../../03-tutorials/00-observability/obsv-03-define-alerting-rules-monitor.md), and eventually, [send notifications](../../../03-tutorials/00-observability/obsv-04-send-notifications.md). And remember to [clean up when you're done](../../../03-tutorials/00-observability/obsv-05-clean-up-configuration.md).
- Learn how to set up the [Monitoring Flow](../../../03-tutorials/00-observability.md) for your services in Kyma, in which you [observe your application metrics](../../../03-tutorials/00-observability/obsv-01-observe-application-metrics.md), [set up your Grafana Dashboard](../../../03-tutorials/00-observability/obsv-02-create-and-configure-grafana-dashboard.md), [define alerting rules](../../../03-tutorials/00-observability/obsv-03-define-alerting-rules-monitor.md), and eventually, [send notifications](../../../03-tutorials/00-observability/obsv-04-send-notifications.md). And remember to [clean up when you're done](../../../03-tutorials/00-observability/obsv-05-clean-up-configuration.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Learn how to set up the [Monitoring Flow](../../../03-tutorials/00-observability.md) for your services in Kyma, in which you [observe your application metrics](../../../03-tutorials/00-observability/obsv-01-observe-application-metrics.md), [set up your Grafana Dashboard](../../../03-tutorials/00-observability/obsv-02-create-and-configure-grafana-dashboard.md), [define alerting rules](../../../03-tutorials/00-observability/obsv-03-define-alerting-rules-monitor.md), and eventually, [send notifications](../../../03-tutorials/00-observability/obsv-04-send-notifications.md). And remember to [clean up when you're done](../../../03-tutorials/00-observability/obsv-05-clean-up-configuration.md).
- Learn how to set up the [Monitoring Flow](../../../03-tutorials/00-observability.md) for your services in Kyma, in which you [observe your application metrics](../../../03-tutorials/00-observability/obsv-01-observe-application-metrics.md), [set up your Grafana Dashboard](../../../03-tutorials/00-observability/obsv-02-create-and-configure-grafana-dashboard.md), [define alerting rules](../../../03-tutorials/00-observability/obsv-03-define-alerting-rules-monitor.md), and eventually, [send notifications](../../../03-tutorials/00-observability/obsv-04-send-notifications.md). And remember to [clean up](../../../03-tutorials/00-observability/obsv-05-clean-up-configuration.md) when you're done.

@@ -4,7 +4,7 @@ title: Observability - Useful links

If you're interested in learning more about the Observability area, check out these links:

- Learn how to set up the [Monitoring Flow](../../../03-tutorials/00-observability) for your services in Kyma, in which you [observe your application metrics](../../../03-tutorials/00-observability/obsv-01-observe-application-metrics.md), [set up your Grafana Dashboard](../../../03-tutorials/00-observability/obsv-02-create-and-configure-grafana-dashboard.md), [define alerting rules](../../../03-tutorials/00-observability/obsv-03-define-alerting-rules-monitor.md), and eventually, [send notifications](../../../03-tutorials/00-observability/obsv-04-send-notifications.md). And remember to [clean up when you're done](../../../03-tutorials/00-observability/obsv-05-clean-up-configuration.md).
- Learn how to set up the [Monitoring Flow](../../../03-tutorials/00-observability.md) for your services in Kyma, in which you [observe your application metrics](../../../03-tutorials/00-observability/obsv-01-observe-application-metrics.md), [set up your Grafana Dashboard](../../../03-tutorials/00-observability/obsv-02-create-and-configure-grafana-dashboard.md), [define alerting rules](../../../03-tutorials/00-observability/obsv-03-define-alerting-rules-monitor.md), and eventually, [send notifications](../../../03-tutorials/00-observability/obsv-04-send-notifications.md). And remember to [clean up when you're done](../../../03-tutorials/00-observability/obsv-05-clean-up-configuration.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links here (except for Monitoring Flow) return 404.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed links to deleted documents.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 13, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2022
@kyma-bot kyma-bot merged commit 80ae6db into kyma-project:main Dec 13, 2022
@chrkl chrkl deleted the fix-observability-link branch December 13, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants