Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose metrics endpoint in nodejs functions #17917

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Expose metrics endpoint in nodejs functions #17917

merged 1 commit into from
Aug 7, 2023

Conversation

kwiatekus
Copy link
Contributor

@kwiatekus kwiatekus commented Aug 1, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • initialise metric provider via OTEL SDK
  • expose /metrics endpoint at port 80
  • add prometheus scrape config to svc annotations

Related issue(s)
#17023
#17022

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kwiatekus
Copy link
Contributor Author

/test all

@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 0e3b8e6
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64d0f29621bd220007b41beb
😎 Deploy Preview https://deploy-preview-17917--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2023
@kwiatekus
Copy link
Contributor Author

/test all

3 similar comments
@kwiatekus
Copy link
Contributor Author

/test all

@kwiatekus
Copy link
Contributor Author

/test all

@kwiatekus
Copy link
Contributor Author

/test all

@kwiatekus kwiatekus force-pushed the expose-metrics-in-functions branch from 51a62c6 to e8f0aa9 Compare August 2, 2023 13:05
@kwiatekus
Copy link
Contributor Author

/test all

@kwiatekus kwiatekus marked this pull request as ready for review August 2, 2023 13:40
@kwiatekus kwiatekus requested a review from a team as a code owner August 2, 2023 13:40
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
@kwiatekus
Copy link
Contributor Author

/test all

@kwiatekus kwiatekus added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@kwiatekus kwiatekus modified the milestone: 2.17 Aug 2, 2023
@kwiatekus kwiatekus added area/serverless Issues or PRs related to serverless area/telemetry Issues or PRs related to the telemetry module kind/feature Categorizes issue or PR as related to a new feature. labels Aug 2, 2023
@kwiatekus
Copy link
Contributor Author

/test pull-function-controller-unit-test

@kwiatekus kwiatekus removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@dbadura dbadura assigned dbadura and Cortey and unassigned dbadura Aug 4, 2023
@kwiatekus kwiatekus force-pushed the expose-metrics-in-functions branch from 57c2311 to 0214698 Compare August 4, 2023 09:36
@kwiatekus kwiatekus force-pushed the expose-metrics-in-functions branch from 0214698 to 0e3b8e6 Compare August 7, 2023 13:33
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 7, 2023
@kyma-bot kyma-bot merged commit efc79e8 into kyma-project:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cortey Cortey Cortey approved these changes

Assignees

@Cortey Cortey

Labels
area/serverless Issues or PRs related to serverless area/telemetry Issues or PRs related to the telemetry module kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kwiatekus @kyma-bot @Cortey @dbadura