Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify sample function in docs #17952

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

kwiatekus
Copy link
Contributor

Description

Changes proposed in this pull request:

  • make sure the same code is presented in the apply scenarios ( via UI and kubectl )

Related issue(s)
https://github.com/kyma-project/kyma/pull/17897/files

@kwiatekus kwiatekus requested a review from a team as a code owner August 9, 2023 07:43
@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 0f53bf8
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64d34e3efa612d0007bfa90c
😎 Deploy Preview https://deploy-preview-17952--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kwiatekus kwiatekus added area/documentation Issues or PRs related to documentation area/serverless Issues or PRs related to serverless labels Aug 9, 2023
@kwiatekus kwiatekus added this to the 2.18 milestone Aug 9, 2023
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2023
@kwiatekus kwiatekus force-pushed the unify-sample-function-in-docs branch from a906d60 to f3d5928 Compare August 9, 2023 07:51
@kwiatekus kwiatekus force-pushed the unify-sample-function-in-docs branch from 0f4d43b to 86fdaa2 Compare August 9, 2023 07:53
@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 9, 2023

@kwiatekus: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance 0f53bf8 link false /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 9, 2023
@kyma-bot kyma-bot merged commit 3922edf into kyma-project:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/serverless Issues or PRs related to serverless lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants