Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix application-connector-validator caching #17957

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Aug 9, 2023

Description

Changes proposed in this pull request:

  • fix cache miss issue

Related issue(s)

see also: kyma-project/test-infra#8606

@m00g3n m00g3n requested a review from a team as a code owner August 9, 2023 14:39
@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 759c1ba
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64dced0c747c1a00087c0368
😎 Deploy Preview https://deploy-preview-17957--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2023
@m00g3n m00g3n force-pushed the fix-caching branch 2 times, most recently from 61b0f7f to e793f4a Compare August 9, 2023 14:55
@m00g3n m00g3n added kind/bug Categorizes issue or PR as related to a bug. area/application-connector Issues or PRs related to application connectivity labels Aug 9, 2023
@m00g3n m00g3n requested a review from akgalwas August 9, 2023 15:01
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2023
@m00g3n m00g3n force-pushed the fix-caching branch 3 times, most recently from e2aa328 to 19aeebe Compare August 9, 2023 17:12
@m00g3n
Copy link
Contributor Author

m00g3n commented Aug 10, 2023

/test all

@m00g3n
Copy link
Contributor Author

m00g3n commented Aug 10, 2023

/test pull-central-application-connectivity-validator-unit-test

@Disper Disper changed the title fix caching fix application-connector-validator caching Aug 11, 2023
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 18, 2023
@akgalwas
Copy link
Contributor

/retest

@kyma-bot
Copy link
Contributor

@m00g3n: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-central-application-connectivity-validator-unit-test 759c1ba link false /test pull-central-application-connectivity-validator-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit dad1db6 into kyma-project:main Aug 18, 2023
akgalwas pushed a commit to akgalwas/kyma that referenced this pull request Aug 18, 2023
* fix caching

* code review comments addressed

* update central-application-connectivity-validator test data
kyma-bot pushed a commit that referenced this pull request Aug 18, 2023
* fix application-connector-validator caching (#17957)

* fix caching

* code review comments addressed

* update central-application-connectivity-validator test data

* Application Connectivity Validator image bumped.

---------

Co-authored-by: marcin witalis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants