Preserve EventMesh precomputed hashes #17959
Merged
+222
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
2 tasks
marcobebway
added
kind/bug
marcobebway
force-pushed
the
17951-preserve-eventmesh-precomputed-hashes
branch
2 times, most recently
from
cd504cc to
d6d94d6
Compare
|
/retest |
kyma-bot
added
the
do-not-merge/hold
marcobebway
force-pushed
the
17951-preserve-eventmesh-precomputed-hashes
branch
from
dbdc1b0 to
8c7fa22
Compare
kyma-bot
added
size/L
marcobebway
force-pushed
the
17951-preserve-eventmesh-precomputed-hashes
branch
from
8c7fa22 to
2961e79
Compare
kyma-bot
removed
the
do-not-merge/work-in-progress
k15r
reviewed
Aug 11, 2023
| return NewReconciler(ctx, te.fakeClient, te.logger, te.recorder, te.cfg, te.cleaner, | ||
| te.backend, te.credentials, te.mapper, validator, collector), te.fakeClient | ||
| }, | ||
| wantEv2Hash: int64(2118518533334734626), |
There was a problem hiding this comment.
Can we extract constants for tests like these. Its really hard to read those random numbers and nobody should actually think (s)he has to compare/understand those values
|
/retest |
k15r
approved these changes
Aug 11, 2023
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preserve EventMesh precomputed hashes.
Related issue(s)