Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configured webhook auth secret in eventing-controller #18028

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

grischperl
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Switch feature flag on

Related issue(s)

#18010

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4d20a87

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 4d20a87
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64e4c87de3af200008908b67
😎 Deploy Preview https://deploy-preview-18028--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@grischperl
Copy link
Contributor Author

/test all

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2023
@grischperl grischperl linked an issue Aug 22, 2023 that may be closed by this pull request
1 task
@grischperl
Copy link
Contributor Author

/retest

2 similar comments
@grischperl
Copy link
Contributor Author

/retest

@grischperl
Copy link
Contributor Author

/retest

@grischperl grischperl marked this pull request as ready for review August 23, 2023 12:05
@grischperl grischperl requested a review from a team as a code owner August 23, 2023 12:05
@grischperl grischperl requested a review from muralov August 23, 2023 12:05
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2023
@muralov
Copy link
Contributor

muralov commented Aug 23, 2023

Let's first roll-out EAM on stage and production.

@mfaizanse mfaizanse added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 25, 2023
@mfaizanse mfaizanse removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2023
@kyma-bot kyma-bot merged commit eadd18d into kyma-project:main Aug 25, 2023
@k15r k15r added the area/eventing Issues or PRs related to eventing label Aug 28, 2023
@k15r k15r changed the title Switch flag Use configured webhook auth secret in eventing-controller Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch feature flag to true to use the secret created by the auth manager
5 participants