-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature flag to disable provisioning of NATS as part of eventing #18041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for kyma-project pending review.Visit the deploys page to approve it
|
mfaizanse
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 24, 2023
kyma-bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 24, 2023
5 tasks
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/test pre-main-kyma-gardener-gcp-eventing-upgrade |
/retest |
muralov
approved these changes
Aug 29, 2023
mfaizanse
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Aug 29, 2023
This was referenced Aug 29, 2023
mfaizanse
added a commit
to mfaizanse/kyma
that referenced
this pull request
Aug 29, 2023
kyma-project#18041) * Added feature flag to disable provisioning of NATS as part of eventing * image bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/eventing
Issues or PRs related to eventing
lgtm
Looks good to me!
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
kyma deploy --source=PR-18041 --profile=production --value eventing.global.jetstream.enabled=false
Related issue(s)