Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove content from telemetry component docs and refer to new module docs #18042

Merged
merged 5 commits into from
Aug 29, 2023
Merged

docs: Remove content from telemetry component docs and refer to new module docs #18042

merged 5 commits into from
Aug 29, 2023

Conversation

NHingerl
Copy link
Contributor

@NHingerl NHingerl commented Aug 24, 2023

Description

Changes proposed in this pull request:

  • remove Telemetry docs from Components section
  • refer to Telemetry module docs instead
  • adjust resource files and makefile

Related issue(s)

@NHingerl NHingerl added area/documentation Issues or PRs related to documentation area/telemetry Issues or PRs related to the telemetry module labels Aug 24, 2023
@NHingerl NHingerl requested a review from a team as a code owner August 24, 2023 16:02
@netlify
Copy link

netlify bot commented Aug 24, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 68bf4f7

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 24, 2023
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 68bf4f7
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64ecae113eecd30008116029
😎 Deploy Preview https://deploy-preview-18042--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NHingerl NHingerl requested a review from a-thaler August 24, 2023 16:03
@NHingerl NHingerl self-assigned this Aug 24, 2023
@shorim shorim self-assigned this Aug 25, 2023
@a-thaler
Copy link
Contributor

Looks good in general. Can you please do the same for the custom resources pages. And remove them from generation (in the makefile)

@a-thaler a-thaler changed the title refer to telemetry module docs docs: remove content from telemetry component docs and refer to new module docs Aug 25, 2023
@a-thaler a-thaler mentioned this pull request Aug 25, 2023
47 tasks
@skhalash skhalash changed the title docs: remove content from telemetry component docs and refer to new module docs docs: Remove content from telemetry component docs and refer to new module docs Aug 25, 2023
@NHingerl NHingerl requested review from k15r and a team as code owners August 28, 2023 13:54
@NHingerl
Copy link
Contributor Author

@a-thaler I removed the custom resources pages. Please check if I did it correctly.

@kyma-bot
Copy link
Contributor

@NHingerl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance 68bf4f7 link false /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 28, 2023
@nataliasitko nataliasitko added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@NHingerl NHingerl removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@kyma-bot kyma-bot merged commit fb2bdde into kyma-project:main Aug 29, 2023
@NHingerl NHingerl deleted the refer-to-telemetry-module-docs branch August 29, 2023 15:02
@a-thaler a-thaler added this to the 2.19 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/telemetry Issues or PRs related to the telemetry module lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants