Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profiles from webhook #18114

Conversation

MichalKalke
Copy link
Contributor

@MichalKalke MichalKalke commented Sep 5, 2023

Description

Cleanup presets for function pod replication.

Changes proposed in this pull request:

  • Delete presets from webhook_config.yaml
  • Delete ReplicasPreset
  • Delete defaultScaling function
  • Add label to skip tests

Related issue(s)
kyma-project/serverless#252

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 42598c2

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 42598c2
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6502aeb083d51b0008d2107b
😎 Deploy Preview https://deploy-preview-18114--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2023
@MichalKalke MichalKalke force-pushed the remove-profiles-for-function-replicas-v2 branch from 9ed5b93 to 2b16bb6 Compare September 6, 2023 11:37
@MichalKalke MichalKalke marked this pull request as ready for review September 6, 2023 12:07
@MichalKalke MichalKalke requested a review from a team as a code owner September 6, 2023 12:07
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2023
@MichalKalke
Copy link
Contributor Author

/test pull-function-controller-lint

@MichalKalke MichalKalke added the area/serverless Issues or PRs related to serverless label Sep 6, 2023
@dbadura dbadura self-assigned this Sep 6, 2023
@pPrecel pPrecel assigned dbadura and unassigned pPrecel Sep 13, 2023
@pPrecel pPrecel force-pushed the remove-profiles-for-function-replicas-v2 branch from 92d7ec8 to f151a31 Compare September 13, 2023 17:13
@pPrecel pPrecel force-pushed the remove-profiles-for-function-replicas-v2 branch from f151a31 to 42598c2 Compare September 14, 2023 06:56
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 14, 2023
@kyma-bot kyma-bot merged commit bff2f21 into kyma-project:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants