Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monitoring component #18265

Merged
merged 30 commits into from
Oct 18, 2023

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Oct 5, 2023

Description

Changes proposed in this pull request:

  • Remove resources folder for monitoring component
  • Remove CRDs for monitoring component
  • fast-integration tests:
    • remove monitoring tests
    • remove unused audit-log tests
    • remove eventingMonitoringTest
  • Adjust documentation
  • Add migration guide and a cleanup script for:
  • Remove grafana dashboards (configmaps) from following components:
    • eventing
    • ory
  • set prometheus.io/scrape annotation to false for services in ory and api-gateway components, as they are not exposing custom metrics

Related issue(s)

#18258

@shorim shorim added area/monitoring Issues or PRs related to the monitoring module (deprecated) do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 5, 2023
@shorim shorim requested review from a team as code owners October 5, 2023 03:23
@shorim shorim requested a review from grischperl October 5, 2023 03:23
@netlify
Copy link

netlify bot commented Oct 5, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit aec5e5b

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit aec5e5b
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/652f9336a2fea400083020f8
😎 Deploy Preview https://deploy-preview-18265--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 5, 2023
@shorim
Copy link
Contributor Author

shorim commented Oct 5, 2023

/test pre-main-kyma-gardener-gcp-eventing

NHingerl
NHingerl previously approved these changes Oct 5, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 9, 2023
@shorim
Copy link
Contributor Author

shorim commented Oct 9, 2023

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@shorim shorim dismissed stale reviews from mmitoraj and jeremyharisch via 1d6e7da October 17, 2023 14:17
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 17, 2023
@shorim
Copy link
Contributor Author

shorim commented Oct 17, 2023

/retest

NHingerl
NHingerl previously approved these changes Oct 17, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 17, 2023
a-thaler
a-thaler previously approved these changes Oct 17, 2023
docs/README.md Outdated Show resolved Hide resolved
Co-authored-by: Nina Hingerl <[email protected]>
@shorim shorim dismissed stale reviews from a-thaler and NHingerl via aec5e5b October 18, 2023 08:11
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 18, 2023
@triffer triffer self-requested a review October 18, 2023 12:37
@shorim
Copy link
Contributor Author

shorim commented Oct 18, 2023

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 18, 2023

@shorim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d e23f818 link true /test pre-main-kyma-integration-k3d

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shorim
Copy link
Contributor Author

shorim commented Oct 18, 2023

/retest

@kyma-bot kyma-bot merged commit dabe4dd into kyma-project:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants