Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tokenrequest CR #1965

Merged
merged 7 commits into from
Dec 19, 2018
Merged

Rename tokenrequest CR #1965

merged 7 commits into from
Dec 19, 2018

Conversation

franpog859
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Rename tokenrequest.connectorservice.kyma-project.io to tokenrequest.applicationconnector.kyma-project.io
  • Coherent naming across Kyma components

Related issue(s)

See #1930

@franpog859 franpog859 added kind/feature Categorizes issue or PR as related to a new feature. WIP area/application-connector Issues or PRs related to application connectivity labels Dec 7, 2018
@franpog859 franpog859 added this to the Sprint_Framefrog_7 milestone Dec 7, 2018
@franpog859 franpog859 requested a review from a team as a code owner December 12, 2018 07:23
@franpog859 franpog859 removed the WIP label Dec 12, 2018
@Szymongib Szymongib self-assigned this Dec 12, 2018
Copy link
Contributor

@Szymongib Szymongib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either rename kyma/components/connection-token-handler/pkg/apis/addtoscheme_connectorservice_v1alpha1.go or move the functionality to kyma/components/connection-token-handler/pkg/apis/apis.go

@franpog859 franpog859 merged commit 0910a14 into kyma-project:master Dec 19, 2018
@franpog859 franpog859 deleted the 1930-Rename-tokenrequest-CR branch February 20, 2019 14:21
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants