Remote Environment Controller implementation #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymongib
requested review from
kazydek,
klaudiagrz,
lilitgh,
pbochynski,
PK85,
suleymanakbas91 and
tomekpapiernik
as code owners
Szymongib
force-pushed
the
remote-env-controller
branch
from
2333103 to
11487d9
Compare
Szymongib
added
kind/feature
Szymongib
changed the title
This was referenced Sep 11, 2018
janmedrek
requested changes
Sep 12, 2018
| } | ||
| } | ||
|
|
||
| // TODO: consider returning error to requeue the request |
There was a problem hiding this comment.
Do we need to requeue delete request? Seems like tiller.UninstallRelease RPC does it for us, please double-check that.
| } | ||
| } | ||
|
|
||
| // ListReleases . |
There was a problem hiding this comment.
Redundant commentary in this file :)
suleymanakbas91
approved these changes
Sep 12, 2018
PK85
approved these changes
Sep 12, 2018
janmedrek
approved these changes
Sep 12, 2018
klaudiagrz
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Part of #416