Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-click-configuration updated with nodeport notice for local installation #600

Merged
merged 5 commits into from
Sep 10, 2018

Conversation

tomekpapiernik
Copy link
Contributor

Description

Changes proposed in this pull request:

  • one-click-configuration updated with nodeport notice for local installation
  • minor tweaks: formatting + introduction wording

Related issue(s)
solves #374

@tomekpapiernik tomekpapiernik added kind/feature Categorizes issue or PR as related to a new feature. area/documentation Issues or PRs related to documentation area/application-connector Issues or PRs related to application connectivity labels Sep 10, 2018
@tomekpapiernik tomekpapiernik self-assigned this Sep 10, 2018
@tomekpapiernik tomekpapiernik requested review from lszymik and a user September 10, 2018 09:22
"token":"example-token-123"
}
```
When you connect an external solution to a local Kyma deployment, you must set NodePort of the `core-nginx-ingress-controller` for the Gateway Service and for the Event Service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must set a NodePort ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's missing an article, but I'd say it should be "the".

@tomekpapiernik tomekpapiernik merged commit 56c55e2 into kyma-project:master Sep 10, 2018
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants