generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Generate global constant and sec scan config for docker images #1671
Merged
shorim
merged 42 commits into
kyma-project:main
from
hisarbalik:refactor-global-constants
Dec 17, 2024
Merged
chore: Generate global constant and sec scan config for docker images #1671
shorim
merged 42 commits into
kyma-project:main
from
hisarbalik:refactor-global-constants
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emetry-manager into refactor-global-constants
…emetry-manager into refactor-global-constants
skhalash
previously requested changes
Dec 16, 2024
Co-authored-by: Stanislav Khalash <[email protected]>
k15r
reviewed
Dec 16, 2024
NHingerl
approved these changes
Dec 17, 2024
shorim
approved these changes
Dec 17, 2024
jeffreylimnardy
pushed a commit
to jeffreylimnardy/telemetry-manager
that referenced
this pull request
Dec 18, 2024
…kyma-project#1671) Co-authored-by: Korbinian Stoemmer <[email protected]> Co-authored-by: Stanislav Khalash <[email protected]> Co-authored-by: Stanislav Khalash <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Documentation changes
area/release
Release creation or process
area/tests
Writing/adding/Refactoring tests or checks
cla: yes
Indicates the PR's author has signed the CLA.
kind/chore
Categorizes issue or PR as related to a chore.
lgtm
Looks good to me!
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any docker image update requires updating several files, such as source code and yaml files. To make the module release and image bumps more straightforward, the docker images are maintained from a single source
.env
file. All other source code and configuration files, likesec-scanner-config.yaml
, are generated from the.env
file.Changes proposed in this pull request (what was done and why):
.env
filesec-scanner-config.yaml
from.env
filesec-scanner-config.yaml
generation to themake generate
target.env
file for benchmark testscheck-clean
target to ensure source code and configuration files are up-to-dateChanges refer to particular issues, PRs or documents:
Traceability
Related Issues
section.