Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Generate global constant and sec scan config for docker images #1671

Merged
merged 42 commits into from
Dec 17, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Dec 11, 2024

Description

Any docker image update requires updating several files, such as source code and yaml files. To make the module release and image bumps more straightforward, the docker images are maintained from a single source .env file. All other source code and configuration files, like sec-scanner-config.yaml, are generated from the .env file.

Changes proposed in this pull request (what was done and why):

  • Add go code generator to generate docker image constants from .env file
  • Generate sec-scanner-config.yaml from .env file
  • Update release docs with new steps
  • Add go code and sec-scanner-config.yaml generation to the make generate target
  • Load docker images from .env file for benchmark tests
  • Add code generation to the check-clean target to ensure source code and configuration files are up-to-date

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner December 11, 2024 14:03
@hisarbalik hisarbalik added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@hisarbalik hisarbalik added kind/chore Categorizes issue or PR as related to a chore. area/tests Writing/adding/Refactoring tests or checks labels Dec 13, 2024
@hisarbalik hisarbalik requested a review from a team as a code owner December 13, 2024 11:42
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@hisarbalik hisarbalik added this to the 1.30.0 milestone Dec 13, 2024
@hisarbalik hisarbalik added area/documentation Documentation changes area/release Release creation or process labels Dec 13, 2024
.golangci.yaml Show resolved Hide resolved
internal/constant/images.go Outdated Show resolved Hide resolved
@hisarbalik hisarbalik requested a review from skhalash December 16, 2024 14:41
@k15r k15r unassigned k15r and skhalash Dec 16, 2024
test/e2e/overrides_test.go Outdated Show resolved Hide resolved
@hisarbalik hisarbalik requested a review from k15r December 17, 2024 06:45
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2024
@shorim shorim enabled auto-merge (squash) December 17, 2024 08:52
@shorim shorim dismissed skhalash’s stale review December 17, 2024 08:55

no more changes are requried

@shorim shorim merged commit 38a6100 into kyma-project:main Dec 17, 2024
43 checks passed
@hisarbalik hisarbalik deleted the refactor-global-constants branch December 17, 2024 09:12
jeffreylimnardy pushed a commit to jeffreylimnardy/telemetry-manager that referenced this pull request Dec 18, 2024
…kyma-project#1671)

Co-authored-by: Korbinian Stoemmer <[email protected]>
Co-authored-by: Stanislav Khalash <[email protected]>
Co-authored-by: Stanislav Khalash <[email protected]>
TeodorSAP added a commit that referenced this pull request Jan 14, 2025
@a-thaler a-thaler mentioned this pull request Jan 17, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation changes area/release Release creation or process area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants