Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename logpipeline samples for consistency reasons #1860

Merged
merged 4 commits into from
Feb 19, 2025
Merged

chore: Rename logpipeline samples for consistency reasons #1860

merged 4 commits into from
Feb 19, 2025

Conversation

TeodorSAP
Copy link
Member

Description

Changes proposed in this pull request (what was done and why):

  • Rename logpipeline samples for consistency reasons
  • Deploying two LogPipelines with the same name ("sample") was not possible 'till now

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@TeodorSAP TeodorSAP requested a review from a team as a code owner February 18, 2025 12:33
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 18, 2025
@github-actions github-actions bot added the kind/chore Categorizes issue or PR as related to a chore. label Feb 18, 2025
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2025
@github-actions github-actions bot added this to the 1.35.0 milestone Feb 18, 2025
@TeodorSAP TeodorSAP added the area/logs LogPipeline label Feb 18, 2025
@TeodorSAP TeodorSAP enabled auto-merge (squash) February 18, 2025 13:43
@hisarbalik hisarbalik self-assigned this Feb 19, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 19, 2025
@TeodorSAP TeodorSAP merged commit c1d5703 into kyma-project:main Feb 19, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TeodorSAP @hisarbalik @kyma-bot