Create bootstrap-helm image #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkab
requested review from
a-thaler,
bszwarc,
clebs,
kazydek,
klaudiagrz,
lilitgh,
tomekpapiernik and
a team
as code owners
tomekpapiernik
approved these changes
Nov 19, 2018
Demonsthere
reviewed
Nov 19, 2018
|
/lgtm |
strekm
approved these changes
Nov 20, 2018
aszecowka
suggested changes
Nov 20, 2018
| @@ -0,0 +1,8 @@ | |||
| FROM eu.gcr.io/kyma-project/prow/bootstrap:0.0.1 | |||
There was a problem hiding this comment.
| FROM eu.gcr.io/kyma-project/prow/bootstrap:0.0.1 | ||
|
|
||
| ENV HELM_VERSION="v2.10.0" | ||
|
|
There was a problem hiding this comment.
aszecowka
reviewed
Nov 21, 2018
prow/jobs/kyma/kyma-integration.yaml
Outdated
| @@ -45,7 +45,7 @@ presubmits: # runs on PRs | |||
| path_alias: github.com/kyma-project/test-infra | |||
| spec: | |||
| containers: | |||
| - image: eu.gcr.io/kyma-project/prow/bootstrap:0.0.1 | |||
| - image: eu.gcr.io/kyma-project/prow/gke-integration:0.0.1 | |||
There was a problem hiding this comment.
regarding image name, I also don't have a good idea how to name it, but maybe bootstrap-helm will be a better option?
jakkab
force-pushed
the
test-kyma-gke-integration
branch
from
5a9dffd to
7e3a816
Compare
|
@aszecowka Comments addressed, please review. |
jakkab
force-pushed
the
test-kyma-gke-integration
branch
2 times, most recently
from
58b8457 to
e181b67
Compare
jakkab
force-pushed
the
test-kyma-gke-integration
branch
from
e181b67 to
edf4e93
Compare
jakkab
force-pushed
the
test-kyma-gke-integration
branch
from
edf4e93 to
61b88b8
Compare
aszecowka
approved these changes
Nov 21, 2018
|
@jakkab: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#139
#20 - continued