Checkout kyma for kyma integration job #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strekm
requested review from
a-thaler,
clebs,
lilitgh and
a team
as code owners
strekm
force-pushed
the
checkout-kyma-for-kyma-integration-job
branch
from
ea89526 to
d2268d7
Compare
aszecowka
approved these changes
Oct 31, 2018
prow/config.yaml
Outdated
| entrypoint: "gcr.io/k8s-prow/entrypoint:v20181019-08e9d55c9" | ||
| sidecar: "gcr.io/k8s-prow/sidecar:v20181019-08e9d55c9" | ||
| gcs_configuration: | ||
| bucket: "prow-mst" |
strekm
force-pushed
the
checkout-kyma-for-kyma-integration-job
branch
from
82bae9e to
33c98d2
Compare
development/create-gcp-secrets.sh
Outdated
| @@ -59,5 +59,5 @@ do | |||
| ENCRYPTED_FILE="${FILE}.${EXTENSTION}" | |||
| gsutil cp gs://${BUCKET}/${ENCRYPTED_FILE} ${TMP_DIR}/${FILE} | |||
| gcloud kms decrypt --location "${LOCATION}" --keyring "${KEYRING}" --key "${KEY}" --ciphertext-file "${TMP_DIR}/${FILE}" --plaintext-file "${TMP_DIR}/${FILE}" | |||
| kubectl create secret generic "${FILE}" --from-file="${TMP_DIR}/${FILE}" | |||
| kubectl create secret generic "${FILE}" --from-file="service-account.json"="${TMP_DIR}/${FILE}" | |||
There was a problem hiding this comment.
We should better use "create or replace" approach here - allows for updates of existing secrets.
My proposal goes like this:
kubectl create secret generic secret3 --from-file="aaa.txt"="secret1.json" --dry-run -o yaml | kubectl apply -f -
There was a problem hiding this comment.
I prepared issue for that: #88
strekm
force-pushed
the
checkout-kyma-for-kyma-integration-job
branch
from
33c98d2 to
e4438fe
Compare
aszecowka
approved these changes
Nov 5, 2018
|
@strekm: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #20