Reserve static IP address on GCP #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfurgol
requested review from
a-thaler,
clebs,
lilitgh and
a team
as code owners
16 tasks
strekm
approved these changes
Nov 7, 2018
aszecowka
approved these changes
Nov 8, 2018
crabtree
reviewed
Nov 8, 2018
prow/scripts/reserve-ip-address.sh
Outdated
|
|
||
| set -o errexit | ||
|
|
||
| if [ -z "$GCLOUD_PROJECT_NAME" ]; then |
There was a problem hiding this comment.
Shouldn't we make the variable names consistent in all the scripts? Here we have GCLOUD_PROJECT_NAME and in the provision-cluster.sh we have PROJECT. Both those variables handles the same parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Provisioning GKE cluster for integration tests #20