Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX nn ModuleList and ParameterList #44

Merged
merged 23 commits into from
Apr 18, 2024
Merged

FIX nn ModuleList and ParameterList #44

merged 23 commits into from
Apr 18, 2024

Conversation

xir4n
Copy link
Collaborator

@xir4n xir4n commented Apr 18, 2024

fix #42

@xir4n xir4n requested a review from lostanlen April 18, 2024 16:54
@lostanlen
Copy link
Contributor

This PR does fix #42 but also seems to include commits from #40 "ENH support all length"

tests/test_nn.py Outdated
in_channels=x.shape[1],
)
x = layer_i(x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert that the layer is of the right type ?

@lostanlen
Copy link
Contributor

rebased

@lostanlen lostanlen merged commit 4da91a8 into main Apr 18, 2024
3 checks passed
@xir4n xir4n deleted the fix-42 branch April 19, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MuReNNDirect: Python list in torch.nn.Module
2 participants