-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH MuReNNDirect.to_conv1d()
#56
Conversation
commit bb7241cd6e9668bd545bd4218ef60efb3a225746 Author: Xiran <[email protected]> Date: Tue Jul 23 09:37:35 2024 +0200 enable gpu commit ef89866 Author: Xiran <[email protected]> Date: Wed Jun 26 23:19:54 2024 +0200 FEAT nb of conv1d filters per scale commit d824ad9 Author: Xiran <[email protected]> Date: Sun Jun 23 23:11:50 2024 +0200 complex conv1d-->real conv1d
Another breaking change is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 👏🏻 👏🏻 👏🏻 👏🏻
murenn/dtcwt/nn.py
Outdated
self.C = in_channels | ||
if isinstance(Q, int): | ||
self.Q = [Q for j in range(J)] | ||
elif isinstance(Q, (dict, list)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think supporting dict
is not necessary. list
is sufficient
[3, 4, 5, 2]
is more explicit than {0: 3, 1: 3, 3: 5, 4: 2}
remove properties, conflict revolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work.
This will require detailed release notes !
What's Changed:
to_conv1d
as described inMuReNNDirect.to_conv1d()
#45.or dictionaryinstead of an integer.Conv1d
kernel sizes inMuReNNDirect
are no longer equal to theT
; they are now equal toT * Q[j]
whereQ[j]
is the number of filters per octave at octavej
.J_phi
to specify the number of levels of downsampling inMuReNNDirect
.MuReNNDirect
has been changed from a 5-dimensional tensor with shape(B, C, Q, J, T)
to a 4-dimensional tensor with shape(B, C, sum(Q_j), T//2**J_phi)
. This is a breaking change.alternate_gh
is now false