-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi wallet support #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be breaking - I can no longer reveal seed phrase in this build.
Error in UI, and terminal output:
Note: In order to run this branch, and aware of the fact that I did a full resync with Chikeichan's recent branch, I removed the directory at ~/Library/Application Support/Electron/hsd_data/wallet
and to avoid incompatibility issues. I also deleted package-lock
and node_modules
before npm run dev
normally.
Let me know if I need to do more locally to test this properly. Some of my comments are UI only so might be relevant either way.
@@ -314,15 +314,6 @@ export default class Settings extends Component { | |||
{ this.renderContent() } | |||
<Switch> | |||
<Route path="/settings/wallet/account-index" component={AccountIndexModal} /> | |||
<Route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q for @mslipper : is there no way to remove a wallet? I checked |
@sdtsui wallet removal is implemented in walletDB but not exposed in the API because I think we're afraid users will destroy their money. |
Thanks @mslipper ! I have pulled and ran the branch with no issues. Seems like the two issues from @sdtsui are already resolved. @sdtsui we should include in our release note about the @pinheadmz is the concern about the users not backing up their seed phrase + unrevealed bids? or do you mean that the wallet removal method could be unsafe to use (i.e. removing one wallet leading to loss of data form another)? Trying to see if this is something the warning modal will address, as we already have a "remove wallet" button with a warning modal. It would be nice if user can remove individual wallet. |
Here is an experimental branch with multi account support + rescan filter fix rebased on top for anyone interested in testing. I am currently running the branch to identify issues to work on prior to next release candidate. |
No description provided.