Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi wallet support #233

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Add multi wallet support #233

merged 4 commits into from
Oct 19, 2020

Conversation

mslipper
Copy link
Contributor

No description provided.

Copy link
Contributor

@sdtsui sdtsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be breaking - I can no longer reveal seed phrase in this build.

Error in UI, and terminal output:
Screen Shot 2020-10-16 at 12 27 35 AM

Note: In order to run this branch, and aware of the fact that I did a full resync with Chikeichan's recent branch, I removed the directory at ~/Library/Application Support/Electron/hsd_data/wallet and to avoid incompatibility issues. I also deleted package-lock and node_modules before npm run dev normally.

Let me know if I need to do more locally to test this properly. Some of my comments are UI only so might be relevant either way.

@@ -314,15 +314,6 @@ export default class Settings extends Component {
{ this.renderContent() }
<Switch>
<Route path="/settings/wallet/account-index" component={AccountIndexModal} />
<Route
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like something changed about the way you're working with routes in settings - I'm getting a warning in console every time I execute that code path in Settings. Details below:

slash-account

@sdtsui
Copy link
Contributor

sdtsui commented Oct 16, 2020

Q for @mslipper : is there no way to remove a wallet? I checked hsd-dev.org, I guess the only way to do it is delete the wallet folder and re-add the relevant wallets manually?

@pinheadmz
Copy link
Contributor

@sdtsui wallet removal is implemented in walletDB but not exposed in the API because I think we're afraid users will destroy their money.

@chikeichan
Copy link
Contributor

chikeichan commented Oct 17, 2020

Thanks @mslipper ! I have pulled and ran the branch with no issues. Seems like the two issues from @sdtsui are already resolved. My only comment is that i think we should default the account dropdown selector to allison if allison exists. This lowers confusion for existing users who is coming from an old version. wdyt? see #236

@sdtsui we should include in our release note about the allison key for existing user upgrading.

@pinheadmz is the concern about the users not backing up their seed phrase + unrevealed bids? or do you mean that the wallet removal method could be unsafe to use (i.e. removing one wallet leading to loss of data form another)? Trying to see if this is something the warning modal will address, as we already have a "remove wallet" button with a warning modal. It would be nice if user can remove individual wallet.

@chikeichan chikeichan self-requested a review October 17, 2020 07:13
@chikeichan chikeichan mentioned this pull request Oct 17, 2020
3 tasks
@chikeichan
Copy link
Contributor

Here is an experimental branch with multi account support + rescan filter fix rebased on top for anyone interested in testing. I am currently running the branch to identify issues to work on prior to next release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants