Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy vint style checking #18

Merged
merged 3 commits into from
Feb 5, 2022
Merged

Satisfy vint style checking #18

merged 3 commits into from
Feb 5, 2022

Conversation

LRitzdorf
Copy link
Collaborator

Please describe the changes this pull request does and why it should be merged:

This PR makes some minor changes to style in relevant Vimscript files, so that the recently-merged (#17) CI linting step passes cleanly.

Note that vint has a bug where their next-line syntax isn't recognized, so for now, we work around this by disabling the relevant check for one line, then reenabling it.

Terms

vint's GitHub page advertises a `next-line` syntax that is currently
broken. This commit uses a (slightly awkward) workaround, until vint's
developers decide to update the PyPI version of vint.

Relevant vint issue: vint/329
@LRitzdorf LRitzdorf marked this pull request as ready for review February 4, 2022 04:53
@LRitzdorf LRitzdorf requested a review from l-zeuch as a code owner February 4, 2022 04:53
@LRitzdorf
Copy link
Collaborator Author

LRitzdorf commented Feb 4, 2022

Now that CI is functioning properly, do we also want to add a status badge to the README?

@l-zeuch
Copy link
Owner

l-zeuch commented Feb 4, 2022

Now that CI is functioning properly, do we also want to add a status badge to the README?

Sounds reasonable, would make for some nice overview.

Looks nice and give some neat overview : )
@l-zeuch l-zeuch merged commit af1c284 into master Feb 5, 2022
@l-zeuch
Copy link
Owner

l-zeuch commented Feb 5, 2022

Perfect, thanks!

@l-zeuch l-zeuch deleted the ci/style-cleanup branch February 5, 2022 01:41
l-zeuch added a commit that referenced this pull request Feb 5, 2022
@l-zeuch l-zeuch modified the milestones: Done With, Backlog, Done May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants