Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix oapi-codegen error during make #186

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

levaitamas
Copy link
Member

make fails due to an oapi-codegen error:

$ make
go generate ./pkg/config/...
# github.com/deepmap/oapi-codegen/v2/pkg/util
/home/lt/go/pkg/mod/github.com/deepmap/oapi-codegen/[email protected]/pkg/util/loader.go:24:45: undefined: openapi3.CircularReferenceCounter
/home/lt/go/pkg/mod/github.com/deepmap/oapi-codegen/[email protected]/pkg/util/loader.go:26:12: undefined: openapi3.CircularReferenceCounter
/home/lt/go/pkg/mod/github.com/deepmap/oapi-codegen/[email protected]/pkg/util/loader.go:33:12: undefined: openapi3.CircularReferenceCounter
pkg/config/client/cds_api.go:1: running "go": exit status 1
# github.com/deepmap/oapi-codegen/v2/pkg/util
/home/lt/go/pkg/mod/github.com/deepmap/oapi-codegen/[email protected]/pkg/util/loader.go:24:45: undefined: openapi3.CircularReferenceCounter
/home/lt/go/pkg/mod/github.com/deepmap/oapi-codegen/[email protected]/pkg/util/loader.go:26:12: undefined: openapi3.CircularReferenceCounter
/home/lt/go/pkg/mod/github.com/deepmap/oapi-codegen/[email protected]/pkg/util/loader.go:33:12: undefined: openapi3.CircularReferenceCounter
pkg/config/server/server.go:1: running "go": exit status 1
make: *** [Makefile:22: generate] Error 1

This PR fixes this issue by upgrading oapi-codegen.

demo
$ make
go generate ./pkg/config/...
go fmt ./...
go vet ./...
go build -trimpath -ldflags "-s -w -X main.version=v1.0.0-39-g77140bad -X main.commitHash=77140ba -X main.buildDate=2025-01-09T11:29:43+0100" -o bin//stunnerd cmd/stunnerd/main.go
go build -trimpath -ldflags "-s -w -X main.version=v1.0.0-39-g77140bad -X main.commitHash=77140ba -X main.buildDate=2025-01-09T11:29:43+0100" -o bin//turncat cmd/turncat/main.go
go build -trimpath -ldflags "-s -w -X main.version=v1.0.0-39-g77140bad -X main.commitHash=77140ba -X main.buildDate=2025-01-09T11:29:43+0100" -o bin//stunnerctl cmd/stunnerctl/*.go
go build -trimpath -ldflags "-s -w -X main.version=v1.0.0-39-g77140bad -X main.commitHash=77140ba -X main.buildDate=2025-01-09T11:29:43+0100" -o bin//icetester cmd/icetester/main.go

@levaitamas levaitamas merged commit f649b59 into main Jan 9, 2025
6 checks passed
@levaitamas levaitamas deleted the oapi-codegen-fix branch January 9, 2025 14:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12688299205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.752%

Totals Coverage Status
Change from base Build 12374628963: 0.0%
Covered Lines: 1052
Relevant Lines: 1446

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants