Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase Integration #48

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

guillo071191
Copy link

No description provided.

Copy link
Contributor

@danielgomezrico danielgomezrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some minor questions

android/build.gradle Outdated Show resolved Hide resolved
android/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
ios/flutter_segment.podspec Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
@@ -37,9 +36,11 @@ android {
implementation 'com.segment.analytics.android:analytics:4.10.4'
implementation 'com.segment.analytics.android.integrations:amplitude:3.1.0'
implementation 'com.appsflyer:segment-android-integration:6.5.2'
implementation 'com.segment.analytics.android.integrations:firebase:2.3.3'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aar package should be preferred to not get resource not found errors:

implementation 'com.segment.analytics.android.integrations:firebase:2.3.3@aar'

please see: https://segment.com/docs/connections/destinations/catalog/firebase/#getting-started-on-android

Note: The Firebase SDK requires android resources which are available on aar packages. Use the aar package when adding the Segment-Firebase SDK.

@AbelTarazona
Copy link

Hello, is there any news about this PR?

@0x0-14
Copy link

0x0-14 commented Jan 18, 2023

@danielgomezrico Will this ever be merged?

@danielgomezrico
Copy link
Contributor

danielgomezrico commented Jan 18, 2023

Hi @0x0-14 @AbelTarazona, this is not merged because:

If you need to use it you could point your pubspec to this branch and use it (but be careful, maybe doing a fork and using your own is safer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants