-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase Integration #48
base: master
Are you sure you want to change the base?
Conversation
Update: build gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left some minor questions
@@ -37,9 +36,11 @@ android { | |||
implementation 'com.segment.analytics.android:analytics:4.10.4' | |||
implementation 'com.segment.analytics.android.integrations:amplitude:3.1.0' | |||
implementation 'com.appsflyer:segment-android-integration:6.5.2' | |||
implementation 'com.segment.analytics.android.integrations:firebase:2.3.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aar
package should be preferred to not get resource not found
errors:
implementation 'com.segment.analytics.android.integrations:firebase:2.3.3@aar'
please see: https://segment.com/docs/connections/destinations/catalog/firebase/#getting-started-on-android
Note: The Firebase SDK requires android resources which are available on aar packages. Use the aar package when adding the Segment-Firebase SDK.
Hello, is there any news about this PR? |
@danielgomezrico Will this ever be merged? |
Hi @0x0-14 @AbelTarazona, this is not merged because:
If you need to use it you could point your pubspec to this branch and use it (but be careful, maybe doing a fork and using your own is safer) |
No description provided.