Fix for iOS Application Installed event #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this and can see the events being fired |
This was referenced Aug 15, 2022
danielgomezrico
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is a workaround fix for the
Application Installedevents not firing when setting the config via dart and not via a file (info.plist), issue #26.Fix Details:
Due to the method sequence and the way the native library works, described here, we need to either call the dart code
Segment.config()indidFinishLaunchingWithOptions(), similar to how the configFromFile works or send theApplication Installedevent when we call the dart codeSegment.config().As I dont think there is an easy way to call
Segment.config()in the native codedidFinishLaunchingWithOptions(), I have instead opted to add a similar method to the way the native code works when sendingApplication Installed/Application Updatedevents, this code is here.This will make use of the same
NSUserDefaultskeys as the native library and manually send the events.This maybe isn't the best way to explain this fix so happy to chat. Also keep up the good work 💙.