-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for logging in with Contentful OAuth #525
Allow for logging in with Contentful OAuth #525
Conversation
…-preview-changes-when-logged-in
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
81c2627
to
de46169
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small things and then good to merge.
I know w've got login/logout tests, but a good follow-up would be to add some tests specific to the OAuth login flow. That's probably more suited to puppeteer, I'd think?
src/lib/components/ContentfulLoginLink/ContentfulLoginLink.svelte
Outdated
Show resolved
Hide resolved
e40eca3
to
a558a0e
Compare
…anges-when-logged-in' into benaiah/allow-logging-in-with-contentful-account
…anges-when-logged-in' into benaiah/allow-logging-in-with-contentful-account
…-in-with-contentful-account
Coverage after merging benaiah/allow-logging-in-with-contentful-account into main will be
Coverage Report
|
Reports for 1152e5c have been deployed to Vercel: |
Proposed changes
Acceptance criteria validation
Other details
Post-merge checklist: