Add Recent News and Events Entity relationships to TopTier and ServiceEntry #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
larsmaxwell
changed the title
hinzed1127
approved these changes
Oct 8, 2024
src/routes/(infoPages)/[topTierPage]/[...serviceGroupPage]/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/(infoPages)/[topTierPage]/[...serviceGroupPage]/+page.server.ts
Outdated
Show resolved
Hide resolved
LouisFettet
reviewed
Oct 8, 2024
src/routes/(infoPages)/[topTierPage]/[...serviceGroupPage]/+page.server.ts
Outdated
Show resolved
Hide resolved
src/routes/(infoPages)/[topTierPage]/[...serviceGroupPage]/+page.svelte
Outdated
Show resolved
Hide resolved
src/routes/(infoPages)/[topTierPage]/[...serviceGroupPage]/+page.svelte
Outdated
Show resolved
Hide resolved
|
Coverage after merging larsmaxwell/572/recent-news into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Reports for 3c0c2de have been deployed to Vercel: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #572
Proposed changes
Screenshots
Top Tier:
Acceptance criteria validation
Other details
Alternate solutions
Possible drawbacks
Currently, the tagged content overrides the entity relationships if the tagged content exists. This could be confusing for editors until all the tagged content is removed.
Requested feedback