driver/sshdriver: read from tools #1558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSHDriver now supports the `tools` key in the config to customize the path to `ssh`, `scp`, `sshfs` and `rsync`. It falls back to loading them from the PATH, so there's no change in behaviour if the tools aren't specified. Signed-off-by: Alex Tercete <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
======================================
Coverage 56.1% 56.2%
======================================
Files 170 170
Lines 13225 13233 +8
======================================
+ Hits 7432 7440 +8
Misses 5793 5793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSHDrivernow supports thetoolskey in the config to customize the path tossh,scp,sshfsandrsync. It falls back to loading them from thePATH, so there's no change in behaviour if the tools aren't specified.This is useful when running Labgrid on hosts which don't have these tools installed. It also allows running Labgrid workflows hermetically.
Testing
Manual tests have been done, using
SSHDriverto transfer files and execute commands.Checklist
Fixes #1553