-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qemu enhancements for extra_args #1560
Conversation
extra_args can already be left empty if there are no extra arguments that should be added to the QEMU command line. Allow it to be omitted in such a case, so it doesn't needlessly clutter the YAML. Signed-off-by: Ahmad Fatoum <[email protected]>
When starting QEMU fails, e.g. because of a wrong command line option, its stderr is not printed by default. Fix this to make debugging startup issues easier. Signed-off-by: Ahmad Fatoum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit in the last commit message: replace last now with not. Otherwise looks good.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1560 +/- ##
========================================
- Coverage 56.2% 56.2% -0.1%
========================================
Files 170 170
Lines 13247 13248 +1
========================================
Hits 7449 7449
- Misses 5798 5799 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The barebox test suite adds an --interactive option to pytest, which allows starting QEMU interactively with the Labgrid Environment YAML to allow manual testing. So far, it wasn't possible to use this with an interactive graphic output, because Labgrid allowed only headless displays or none. none is the default and will configure QEMU with -nographic, which can not be overridden later on and -display also has no default value. To support this use case, add a qemu-default option, which instructs Labgrid to not touch -nographic and -display at all. Signed-off-by: Ahmad Fatoum <[email protected]>
812ee75
to
bd60c1c
Compare
Description
The barebox test suite uses Labgrid in CI for QEMU and these are some quality of life improvements around
QEMUDriver
extra_args
:Allow
extra_args
to be emptyShow QEMU stderr for malformed
extra_args
Allow
extra_args
to list display devices and have them shown if requestedhow did you verify the feature works?
Manually by editing the YAML and running Labgrid with QEMUDriver:
extra_args
extra_args
-device ramfb
inextra_args
and settingdisplay
toqemu-default
Checklist