-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
path too long error fix #949
path too long error fix #949
Conversation
Is this the only change needed for MacOS? So far, we only support Linux and I wouldn't make want to make MacOS a supported platform as that could limit us in the future. |
as far as i can tell it's the only thing that has to change, but i can't tell if all features of the client will work, I'm only using the labgrid-client on MacOS and the rest will run on linux machines for the sake of completeness the features that i'm using for the client on MacOS is ssh to the exporter and ser2net connection to the dut it's understandable that only support for linux is desired. For the rest I use the docker-images that I build using the dockerfile I mostly use MacOS natively to be able to debug labgrid via vscode but I could also attach the debugger to the container |
FWIW this also happens on Linux, so its not macOS exclusive. Can you fix the DCO by adding a signed off by? |
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
======================================
Coverage 57.1% 57.1%
======================================
Files 150 150
Lines 11199 11199
======================================
Hits 6402 6402
Misses 4797 4797
Continue to review full report at Codecov.
|
8e3b933
to
1e3e022
Compare
Signed-off-by: Daniel Schick <[email protected]>
1e3e022
to
82b9542
Compare
@Emantor added a signed off by ✅ |
Fixes #948
changes the names for the temporary file_paths from
labgrid-ssh-tmp-
tolg-ssh-
and
labgrid-connection-
tolg-con-
in order to be compatible with MacOS and its longer tempdir-path