Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better support for airgap mode 'exists', secure rke2 token by default, allow setting rke2_node_name, implement local artifact download and push to remote fallback #203

Closed
wants to merge 40 commits into from
Closed

better support for airgap mode 'exists', secure rke2 token by default, allow setting rke2_node_name, implement local artifact download and push to remote fallback #203

wants to merge 40 commits into from

Conversation

simonfelding
Copy link

Description

There's a bunch of stuff in this commit. I realize it could have been multiple pull requests. Sorry about that.

  • added better support for airgap mode 'exists' in rke2.yml
  • deprecate rke2_snapshooter spelling error
  • secure rke2 token by default
  • fix indent of registries config (broke with tls_no_verify set)
  • allow setting rke2_node_name as node name
  • split logical and to multiple lines for readability
  • made the role guess if server or agent based on group it belongs to
  • implement local artifact download and push to remote fallback
  • updated documentation to match

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

reset my local cluster entirely and ran each feature against it.

@MonolithProjects MonolithProjects changed the base branch from main to develop March 15, 2024 15:49
@MonolithProjects MonolithProjects self-assigned this Mar 15, 2024
@MonolithProjects
Copy link
Collaborator

Hi @simonfelding, please resolve the conflicts

paulfantom and others added 26 commits March 27, 2024 22:27
@paulfantom @simonfelding
tasks: copy kube-vip manifests before connecting to first node
e808d3f
@simonfelding
fix: fix role downloads badge
c0393e5
@lukapetrovic-git @simonfelding
add creation of manifests directory
d55c4d9
@julsemaan @simonfelding
Fix RKE2 services restart when configuration changes
e64e892
@tchinmai7 @simonfelding
bug fix to tasks/main.yml
3911026
@simonfelding
Add debug mode
d164d3d
@glennpratt @simonfelding
Improve rolling restart version detection
c33ea7a
@glennpratt @simonfelding
don't restart on first run
23c2d2b
@glennpratt @simonfelding
further fix change detection
35a8840
@hoangphuocbk @simonfelding
update links and add the example to specify the address to advertise
55065bc
@hoangphuocbk @simonfelding
Implement lablabs#179, add rke2_kubevip_args variable to customize ku…
5178708 
…bevip
@simonfelding
feat: parametrize kubevip-cloud-provider-image
a127986
@simonfelding
feat: kubevip-cloud-provider-image default value
107d022
@simonfelding
docs: add rke2_kubevip_cloud_provider_image
9b0b2a8
@strelok899 @simonfelding
adding kubevip IPVS
0a2433b
@strelok899 @simonfelding
fixing typo in the modprob module
79f5e73
@strelok899 @simonfelding
fixing ipvs persistance and proper depoyment
6e264f3
@strelok899 @simonfelding
changing names to lowercase adding to README
11062c3
@koseb9 @simonfelding
feat: Add explicit metrics port 2112
7d6d35b
@koseb9 @simonfelding
feat: Add rke2_kubevip_metrics_port variable
a7c027d
@lukapetrovic-git @simonfelding
add option to specify kubelet arguments
d441db2
@lukapetrovic-git @simonfelding
fix variable name to stay consistent
5bc7e97
@stmcginnis @simonfelding
Minor typo fixes
396aec8 
I noticed a few places in the repo where there were some misspellings.
This is a minor update to correct those instances.

Signed-off-by: Sean McGinnis <[email protected]>
@mueller-ma @simonfelding
Set permissions for downloaded kubeconf
36b8694 
The kubeconfig allows full access to the cluster, so it should be kept secure. Previously it was readable by everyone, now only by the user running Ansible.
@strelok899 @simonfelding
adding kubevip service election
5695c53
@strelok899 @simonfelding
whitespace fix
22e8d77
@simonfelding
Copy link
Author

@MonolithProjects I fixed the conflicts, is it okay now?

@Duke1715
Copy link

Duke1715 commented May 6, 2024

@MonolithProjects Hi! When can we expect the merge? I found some interesting changes there for use that I would like to see in the master.

@simonfelding
Copy link
Author

@MonolithProjects Hi! When can we expect the merge? I found some interesting changes there for use that I would like to see in the master.

Maybe I should split it into multiple PRs, it got kind of large..

@MonolithProjects
Copy link
Collaborator

@MonolithProjects Hi! When can we expect the merge? I found some interesting changes there for use that I would like to see in the master.

Maybe I should split it into multiple PRs, it got kind of large..

Yeah... I think that's a good idea. Plus I see in this PR commits which are already in Master and this makes it harder to review. Please split it and I am sure I can find a time to check it 😉 Thanks!

This was referenced Oct 10, 2024
Closed
Closed
Open
Merged
Merged
Merged
Merged
@simonfelding
Copy link
Author

I split it up into several new pull requests. some of the changes have already been implemented by other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MonolithProjects MonolithProjects

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.