Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test coverage #1266

Closed
wants to merge 3 commits into from
Closed

Dev test coverage #1266

wants to merge 3 commits into from

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Jul 7, 2022

update test coverage rate.

DONE:

  • pkg/utils/logger

TODO:

  • pkg/utils/

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #1266 (7e4f9ec) into main (429bf9e) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 7e4f9ec differs from pull request most recent head 20f755c. Consider uploading reports for the commit 20f755c to get more accurate results

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   53.09%   52.94%   -0.16%     
==========================================
  Files           5        1       -4     
  Lines         420       51     -369     
==========================================
- Hits          223       27     -196     
+ Misses        181       19     -162     
+ Partials       16        5      -11     
Impacted Files Coverage Δ
pkg/apply/utils.go
pkg/apply/reset.go
pkg/apply/scale.go
pkg/apply/run.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429bf9e...20f755c. Read the comment docs.

zzjin added 2 commits July 7, 2022 07:13
2. fix pkg/utils/loger infinite loop
3. improve pkg/utils/logger test coverage rate
@zzjin zzjin force-pushed the dev_test_coverage branch from d1e6483 to 694f24e Compare July 7, 2022 07:14
@zzjin zzjin closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant