chore(aws) rename enable_cloudtrail => use_existing_cloudtrail (#34)

chore(aws) rename enable_cloudtrail => use_existing_cloudtrail Signed-off-by: Scott Ford <[email protected]> Co-authored-by: Salim Afiune <[email protected]>
lacework · Jun 17, 2020 · 1ab3036 · 1ab3036
1 parent e307836
commit 1ab3036
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/aws/modules/cloudtrail/examples/existing-cloudtrail-iam-role/main.tf b/aws/modules/cloudtrail/examples/existing-cloudtrail-iam-role/main.tf
@@ -6,9 +6,9 @@ module "aws_cloudtrail" {
 	source = "../../"
 
 	# Use an existing CloudTrail
-	enable_cloudtrail    = false
-	bucket_name          = "lacework-ct-bucket-7bb591f4"
-	sns_topic_name       = "lacework-ct-sns-7bb591f4"
+	use_existing_cloudtrail    = true
+	bucket_name                = "lacework-ct-bucket-7bb591f4"
+	sns_topic_name             = "lacework-ct-sns-7bb591f4"
 
 	# Use an existing IAM role
 	use_existing_iam_role = true

diff --git a/aws/modules/cloudtrail/examples/existing-cloudtrail/main.tf b/aws/modules/cloudtrail/examples/existing-cloudtrail/main.tf
@@ -6,8 +6,8 @@ module "aws_cloudtrail" {
 	source = "../../"
 
 	# Use an existing CloudTrail
-	enable_cloudtrail    = false
-	bucket_name          = "lacework-ct-bucket-8805c0bf"
-	sns_topic_name       = "lacework-ct-sns-8805c0bf"
+	use_existing_cloudtrail    = true
+	bucket_name                = "lacework-ct-bucket-8805c0bf"
+	sns_topic_name             = "lacework-ct-sns-8805c0bf"
 }
 
diff --git a/aws/modules/cloudtrail/main.tf b/aws/modules/cloudtrail/main.tf
@@ -16,7 +16,7 @@ resource "random_id" "uniq" {
 }
 
 resource "aws_cloudtrail" "lacework_cloudtrail" {
-	count                 = var.enable_cloudtrail ? 1 : 0
+	count                 = var.use_existing_cloudtrail ? 0 : 1
 	name                  = var.cloudtrail_name
 	is_multi_region_trail = true
 	s3_bucket_name        = local.bucket_name
@@ -27,7 +27,7 @@ resource "aws_cloudtrail" "lacework_cloudtrail" {
 # we need the identity of the caller to get their account_id for the s3 bucket
 data "aws_caller_identity" "current" {}
 resource "aws_s3_bucket" "cloudtrail_bucket" {
-	count         = var.enable_cloudtrail ? 1 : 0
+	count         = var.use_existing_cloudtrail ? 0 : 1
 	bucket        = local.bucket_name
 	force_destroy = var.bucket_force_destroy
 	policy        = <<POLICY

diff --git a/aws/modules/cloudtrail/variables.tf b/aws/modules/cloudtrail/variables.tf
@@ -46,10 +46,10 @@ variable "sqs_queue_name" {
 	default = ""
 }
 
-variable "enable_cloudtrail" {
+variable "use_existing_cloudtrail" {
 	type        = bool
-	default     = true
-	description = "Set this to false to use an existing cloudtrail"
+	default     = false
+	description = "Set this to true to use an existing cloudtrail. Default behavior enables new cloudtrail"
 }
 
 variable "cloudtrail_name" {