-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hvac): Add templates for radiant HVAC #349
Conversation
As much as I like radiant, I recommend holding off incorporating the radiant schema until the refactoring work is complete in openstudio-standards. E+ underwent a major update/refactor of radiant systems last year, and I haven't had time to refactor openstudio-standards to ditch the limit fixed-operating hours and controls implemented with EMS objects. This will be done by fall openstudio-standards release. |
Hi @mdahlhausen, Thank you for the feedback. What if we include the current version as it has been requested by several users and then update it once you have the new one released in the fall? |
@mostaphaRoudsari that's fine. I think people can still get use out of it. It might be nice to include a comment or something in the object that the system currently used fixed operating hours for a typical office in the controls. And if they have different occupancy hours or thermostat schedules, they will see a lot of unmet hours. This can be manually edited in the model. |
We realized that we weren't really enforcing this and this wasn't really necessary. So I'm removing the restrictions.
Thanks @mdahlhausen . I should have read your comments here before responding to your email today. Given you comments, I'll definitely hold off on exposing radiant systems on any of our UIs. However, if we don't see anything fundamentally incorrect about the properties that are being exposed in our file schema here, I think I'd rather merge this PR so that the rest of the development team can start thinking about how we'll eventually expose a HVAC template like this since its schema is a bit different from the other HVAC templates. We can always send an update PR to change things and merging this PR now only exposes the radiant systems for a handful of advanced software developers. For these advanced developers, editing the resulting EMS objects and controls with the OpenStudio SDK isn't going to be a very heavy lift. |
🎉 This PR is included in version 1.49.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
@chriswmackey This will be in the next OpenStudio release. |
Resolves ladybug-tools/honeybee-energy#526
Resolves ladybug-tools/honeybee-openstudio-gem#184