fix(dataframe): enable epw dataframe without loaded data

this is part of a fix for a bug found by @eapuertoc fix #154
ladybug-tools · Jun 6, 2021 · 0d118fb · 0d118fb
1 parent 2823edd
commit 0d118fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/ladybug_pandas/dataframe.py b/ladybug_pandas/dataframe.py
@@ -122,6 +122,9 @@ def from_epw(
         Returns:
             pd.DataFrame -- A pandas dataframe. Each column will have a type of LadybugArrayType
         """
+        if not epw.is_data_loaded:
+            epw._import_data()
+
         df = cls(epw._data[6:])
 
         df = df.replace(999999999.0, np.nan)

diff --git a/tests/op_test.py b/tests/op_test.py
@@ -49,13 +49,16 @@ def test_from_collections(epw):
 
     df = DataFrame([epw.dry_bulb_temperature, epw.direct_normal_radiation])
 
+def test_from_epw_with_loaded_data(epw):
+    df = DataFrame.from_epw(epw)
     # should not raise
 
-def test_from_epw(epw):
 
+def test_from_epw_without_loaded_data(epw):
+    epw_path = 'tests/assets/epw/tokyo.epw'
+    epw = EPW(epw_path)
     df = DataFrame.from_epw(epw)
 
-    # should not raise
 
 def test_si_from_si(temp_series):