Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release 2.0.0 #1974

Closed
wants to merge 4 commits into from
Closed

Prepare for release 2.0.0 #1974

wants to merge 4 commits into from

Conversation

FrancoGiachetta
Copy link
Contributor

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Feb 25, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.870 s ±  0.039 s    [User: 26.134 s, System: 0.735 s]
  Range (min … max):   26.843 s … 26.897 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     27.352 s ±  0.024 s    [User: 26.561 s, System: 0.789 s]
  Range (min … max):   27.335 s … 27.369 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.887 s ±  0.030 s    [User: 26.149 s, System: 0.806 s]
  Range (min … max):   14.865 s … 14.908 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     15.020 s ±  0.032 s    [User: 26.392 s, System: 0.831 s]
  Range (min … max):   14.997 s … 15.043 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.213 s ±  0.180 s    [User: 38.938 s, System: 0.926 s]
  Range (min … max):   11.086 s … 11.340 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.955 s ±  0.360 s    [User: 39.404 s, System: 0.917 s]
  Range (min … max):   10.700 s … 11.209 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.02 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.883 s ±  0.388 s    [User: 39.186 s, System: 0.958 s]
  Range (min … max):   10.609 s … 11.157 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.997 s ±  0.194 s    [User: 39.391 s, System: 0.910 s]
  Range (min … max):   10.861 s … 11.134 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.757 s ±  0.186 s    [User: 39.590 s, System: 0.952 s]
  Range (min … max):   10.625 s … 10.888 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.711 s ±  0.141 s    [User: 39.623 s, System: 0.949 s]
  Range (min … max):   10.611 s … 10.810 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.779 s ±  0.019 s    [User: 40.020 s, System: 1.083 s]
  Range (min … max):   10.765 s … 10.792 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.738 s ±  0.165 s    [User: 40.141 s, System: 1.051 s]
  Range (min … max):   10.622 s … 10.855 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.00 ± 0.02 times faster than hyper_threading_main threads: 16


Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (ed94d8c) to head (c632c61).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1974   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         103      103           
  Lines       42512    42512           
=======================================
  Hits        41010    41010           
  Misses       1502     1502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrancoGiachetta
Copy link
Contributor Author

Closed due to the ci errors. Seems like the cache is corrupted.

@FrancoGiachetta FrancoGiachetta deleted the release-2.0.0 branch February 26, 2025 14:04
@FrancoGiachetta FrancoGiachetta mentioned this pull request Feb 26, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants