Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cairo to 2.10rc-0 #986

Merged
merged 28 commits into from
Jan 3, 2025
Merged

update cairo to 2.10rc-0 #986

merged 28 commits into from
Jan 3, 2025

Conversation

FrancoGiachetta
Copy link
Contributor

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Dec 26, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.852 ± 0.047 3.775 3.917 1.00
base dict_insert.cairo (AOT) 4.266 ± 0.161 4.031 4.439 1.11 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 4.063 ± 0.150 3.934 4.456 1.00
head dict_insert.cairo (AOT) 4.355 ± 0.105 4.202 4.567 1.07 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.395 ± 0.036 4.354 4.458 1.00
base dict_snapshot.cairo (AOT) 4.565 ± 0.046 4.489 4.626 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 4.340 ± 0.141 4.163 4.562 1.00
head dict_snapshot.cairo (AOT) 4.465 ± 0.124 4.244 4.623 1.03 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.385 ± 0.034 4.333 4.437 1.00
base factorial_2M.cairo (AOT) 4.514 ± 0.136 4.262 4.718 1.03 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.269 ± 0.087 4.116 4.403 1.00
head factorial_2M.cairo (AOT) 4.516 ± 0.073 4.410 4.635 1.06 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.615 ± 0.061 3.536 3.766 1.00
base fib_2M.cairo (AOT) 3.794 ± 0.029 3.763 3.841 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.809 ± 0.091 3.655 3.911 1.00
head fib_2M.cairo (AOT) 3.926 ± 0.086 3.826 4.071 1.03 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.806 ± 0.033 3.764 3.864 1.00
base linear_search.cairo (AOT) 3.942 ± 0.033 3.885 4.002 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.888 ± 0.063 3.788 3.997 1.00
head linear_search.cairo (AOT) 4.062 ± 0.102 3.945 4.271 1.04 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.901 ± 0.017 3.877 3.924 1.00
base logistic_map.cairo (AOT) 3.981 ± 0.052 3.884 4.035 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 4.070 ± 0.076 3.966 4.166 1.01 ± 0.02
head logistic_map.cairo (AOT) 4.024 ± 0.062 3.964 4.148 1.00

Copy link

github-actions bot commented Dec 26, 2024

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 21.137 ± 0.144 20.976 21.451 106.49 ± 1.33
cairo-native (embedded AOT) 3.965 ± 0.016 3.941 3.984 19.98 ± 0.22
cairo-native (embedded JIT using LLVM's ORC Engine) 3.815 ± 0.037 3.775 3.899 19.22 ± 0.27
cairo-native (standalone AOT with -march=native) 0.198 ± 0.002 0.195 0.203 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.741 ± 0.032 5.694 5.793 17.94 ± 0.51
cairo-native (embedded AOT) 4.138 ± 0.029 4.084 4.182 12.93 ± 0.37
cairo-native (embedded JIT using LLVM's ORC Engine) 3.993 ± 0.018 3.968 4.025 12.48 ± 0.35
cairo-native (standalone AOT with -march=native) 0.320 ± 0.009 0.315 0.343 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.874 ± 0.241 14.719 15.543 10.94 ± 0.20
cairo-native (embedded AOT) 4.254 ± 0.026 4.214 4.294 3.13 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 4.045 ± 0.026 4.010 4.091 2.97 ± 0.03
cairo-native (standalone AOT with -march=native) 1.360 ± 0.011 1.355 1.392 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.642 ± 0.064 14.538 14.727 183.15 ± 0.92
cairo-native (embedded AOT) 3.797 ± 0.029 3.756 3.845 47.50 ± 0.38
cairo-native (embedded JIT using LLVM's ORC Engine) 3.571 ± 0.020 3.547 3.602 44.66 ± 0.27
cairo-native (standalone AOT with -march=native) 0.080 ± 0.000 0.080 0.080 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.761 ± 0.029 5.709 5.799 2884.18 ± 59.00
cairo-native (embedded AOT) 3.884 ± 0.037 3.835 3.940 1944.76 ± 42.78
cairo-native (embedded JIT using LLVM's ORC Engine) 3.760 ± 0.020 3.734 3.796 1882.62 ± 38.68
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.773 ± 0.055 5.694 5.857 23.80 ± 0.23
cairo-native (embedded AOT) 4.028 ± 0.032 3.977 4.079 16.61 ± 0.14
cairo-native (embedded JIT using LLVM's ORC Engine) 3.959 ± 0.026 3.922 4.003 16.32 ± 0.11
cairo-native (standalone AOT with -march=native) 0.243 ± 0.000 0.242 0.243 1.00

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 94.17476% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (8d700c9) to head (97c6b84).

Files with missing lines Patch % Lines
src/libfuncs/gas.rs 88.88% 7 Missing ⚠️
src/libfuncs/bounded_int.rs 97.18% 4 Missing ⚠️
src/debug.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   80.72%   80.88%   +0.15%     
==========================================
  Files         107      107              
  Lines       29268    29470     +202     
==========================================
+ Hits        23626    23836     +210     
+ Misses       5642     5634       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 27, 2024

✅ Code is now correctly formatted.

azteca1998
azteca1998 previously approved these changes Dec 27, 2024
src/libfuncs/bounded_int.rs Outdated Show resolved Hide resolved
src/libfuncs/gas.rs Show resolved Hide resolved
edg-l
edg-l previously approved these changes Jan 3, 2025
@FrancoGiachetta FrancoGiachetta dismissed stale reviews from edg-l and JulianGCalderon via b3d25c8 January 3, 2025 13:03
edg-l
edg-l previously approved these changes Jan 3, 2025
src/types.rs Outdated Show resolved Hide resolved
@azteca1998 azteca1998 enabled auto-merge January 3, 2025 21:03
@azteca1998 azteca1998 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 1b3e7c1 Jan 3, 2025
53 checks passed
@azteca1998 azteca1998 deleted the update-cairo2.10rc branch January 3, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants