fix: Update ext-node.toml
file at init
#189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code executed in the
infrastructure/zk/src/init.ts
to update the contents of theext-node.toml
setting thel1_batch_commit_data_generator_mode
to Validium when is initialized in validium mode.It also creates a struct of
ConfigLine
to keep track of al the necessary data to position itself inside the config file.How to test
In rollup mode:
zk clean --all && zk && zk init
should only modify thechain.toml
updating the values from floating points to integers (not relevant change, only how code is formatted)In Validium mode:
zk clean --all && zk && zk init --validium-mode
should modify thechain.toml
,eth_sender.toml
, andext-node.toml
. The last one should add a line just after the setted section in theConfigLine
parameter.If runned in rollup mode after a validium mode execution, the files should look the same as the actual state (just formatting the floating point numbers to integers)
To test is not necessary to make all the initialization, once the
Updating mode configuration
(first and second step of the init) is finished you can actually see the expected result.