-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👍 add rebase:instant-drop action #151
Conversation
With `rebase:instant-drop` action, users can instantly drop a cursor-selected commit on GinLog.
WalkthroughThe pull request introduces a new rebase functionality in the Changes
Sequence DiagramsequenceDiagram
participant User
participant VimPlugin
participant GitCommand
User->>VimPlugin: Trigger rebase:instant-drop
VimPlugin->>VimPlugin: Gather rebase candidates
VimPlugin->>GitCommand: Execute git rebase --onto
GitCommand-->>VimPlugin: Perform instant drop of commit
VimPlugin-->>User: Rebase completed
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 17 17
Lines 881 881
Branches 108 108
=======================================
Hits 519 519
Misses 362 362 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
denops/gin/action/rebase.ts (1)
85-106
: Consider unifying error handling with other rebase commands.Both
doRebase
anddoRebaseInstantDrop
lack a try/catch approach, whereasdoRebaseInteractive
includes one. It may be beneficial to unify the error handling pattern to ensure consistent user feedback and avoid potential unhandled errors. If theawait
approach is required here (as opposed to the async dispatch indoRebaseInteractive
), you can still wrap it in a similar try/catch pattern and provide consistent messaging if an error occurs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
denops/gin/action/rebase.ts
(2 hunks)
🔇 Additional comments (1)
denops/gin/action/rebase.ts (1)
28-34
: Well-structured command definition.This addition cleanly parallels the existing command definitions, maintaining consistency and readability in the
init
function. Good job!
With
rebase:instant-drop
action, users can instantly drop acursor-selected commit on GinLog.
Summary by CodeRabbit