-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow testing of new unstable PHP versions as draft PRs #37
Conversation
Signed-off-by: Gary Lockett <[email protected]>
Before merging this, we may want to look at testing this out in a downstream repo first by pointing the renovate config to this branch. |
@internalsystemerror can you create a new repo pointing to your fork, perhaps? |
@Ocramius Yup, taken a fork of service manager, enabled renovate for it, will test there and report back 👍 |
We'd have to create a tag, it won't work with branch names :( |
Feel free to push a temporary tag here 👍 |
{
"currentValue": "~7.4.0 || ~8.0.0 || ~8.1.0",
"datasource": "packagist",
"depIndex": 0,
"depName": "php",
"depType": "require",
"skipReason": "unsupported",
"updates": []
} It seems that the PHP field is unsupported. So we may have to do it the old fashioned way. |
Maybe a crazy idea, but could we create a meta package for php as a composer dependency where we add tags for all the versions? |
We can't publish such a package, though? 🤔 |
Adding support for this into renovate should be possible, though with only a month left, maybe not in that time frame. |
If it's automation-tested, shouldn't be massive? 🤔 |
With renovatebot/renovate#18474 now merged, I was going to retest this, however after bringing my fork up to date, However, I think this PR would be fine to merge as the only thing we aren't already using in this change is
If we don't want to use unstable tags, I will update this PR to just disable the automerge and await maintainer response. |
@internalsystemerror before this goes in: how is renovate deciding to apply this only to minor releases? 🤔 |
@Ocramius Sorry, I'm not sure I understand the question there? Do you mean the updates that renovate is offering? Or the branch that it applies to? |
Let me clarify:
Do we care about an upgrade here? How does renovate only consider |
Ah thanks, I get you! That would be handled by the rangeStrategy setting of "widen" for anything in "require": Line 26 in cbcde24
The widen strategy will add the |
Off topic here, but do you think it's worth |
Thanks for clarifying!
Bumping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try this out 👍
Description
In order to test out support for PHP 8.2, this PR will: