Fix: prevent forbidden characters in captcha id and double use of captcha #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 12, 2024 16:20
…tcha Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
|
@mkrasselt1 Your changes would also have to be tested accordingly. Could you add the tests? |
|
I can an I will :) |
added 3 commits
September 26, 2024 03:30
Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
Signed-off-by: Michael Krasselt <[email protected]>
added two tests, should cover both new functions (reuse and id-injection) |
|
are my tests sufficient ? |
samsonasik
approved these changes
Jan 6, 2025
|
Let's give it a try, thank you @mkrasselt1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves this bug:
Closes #13
and another one where attackers could just resend the last captcha over and over again, until the expiration period has passed.
Thats not what i would expect a captcha class to allow
BREAKING CHANGE:
prevents double sending of captchas - invalidates them after successful validation by regeneration of words